epic icon indicating copy to clipboard operation
epic copied to clipboard

feat(ci): valgrind check for memory leaks (DONT UPDATE OR REBASE)

Open wdconinc opened this issue 2 years ago • 2 comments

Briefly, what does this PR introduce?

This adds a new ci check that runs valgrind on the main geometries, and fails out if non-suppressed errors are found. It also prints out the additions to the suppressions file that would be required if it turns out that the error is a false positive.

This branch is intentionally on a non-updated main so it should be able to fail due to a known memory leak that was since fixed.

What kind of change does this PR introduce?

  • [ ] Bug fix (issue #__)
  • [x] New feature (issue #__)
  • [ ] Documentation update
  • [ ] Other: __

Please check if this PR fulfills the following:

  • [ ] Tests for the changes have been added
  • [ ] Documentation has been added / updated
  • [ ] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

wdconinc avatar Sep 30 '23 01:09 wdconinc

@wdconinc Is this going in for February?

rahmans1 avatar Feb 06 '24 19:02 rahmans1

@wdconinc Is this going in for February?

This is a CI feature. Irrelevant for production and won't go in soon due to not completed.

wdconinc avatar Feb 06 '24 19:02 wdconinc