Wouter Deconinck

Results 62 comments of Wouter Deconinck

Increased visibility of the Git installation instruction with headers: ![image](https://user-images.githubusercontent.com/4656391/161393260-807e7b10-a389-4b93-ba5e-7001a40def0d.png) The links to different operating systems are all exactly the same and only serve to give visual weight and ensure...

Confirming that on current `master` this installs all headers when running `make && make install` instead of only CADMesh.hh without the headers it tries to include.

Your issue seems addressed by https://github.com/richgel999/miniz/blob/master/readme.md#Usage > Please use the files from the releases page in your projects. Do not use the git checkout directly! The different source and header...

This is not something that is affecting us anymore in EIC. We did move away from simple disks for the endcaps, so I cannot definitely state that the issue is...

I have applied all outstanding changes, added new version 6.2.4, tested a full build on my system, rebased the branch to current develop, and set it to ready for review....

Added newer versions 6.3.0 and 6.3.1. Full change sets: | versions | qt-base | qt-declarative | qt-quick3d | qt-quicktimeline | qt-shadertools | |---|---|---|---|---|---| | 6.2.4 to 6.3.0 | [diff](https://github.com/qt/qtbase/compare/v6.2.4...v6.3.0) |...

Version 6.3.1 builds fine on my system (*edit: after https://github.com/spack/spack/pull/29555/commits/9cd58cac229d91701225910f3dcabc4993518c93*): ```console 5clmspe [email protected]+accessibility~dbus~examples~framework~gtk+gui~ipo~opengl+shared+sql+ssl+widgets build_type=Release dev_path=/data/develop/qt-base-6.3.1 7jnwd3y [email protected]~ipo build_type=Release dev_path=/data/develop/qt-declarative-6.3.1 6b5qjjd [email protected]~ipo build_type=Release dev_path=/data/develop/qt-quick3d-6.3.1 c6v5qio [email protected]~ipo build_type=RelWithDebInfo dev_path=/data/develop/qt-quicktimeline-6.3.1 ztdh4st [email protected]~ipo build_type=Release...

> I'm wondering if this PR is still a WIP. Yes, and no. I think what's been mostly missing is a downstream package to test this with. Until then it...

I may try to cherry-pick those into this PR, if that's ok with you.

@spackbot fix style