epic icon indicating copy to clipboard operation
epic copied to clipboard
verified publisher icon eic

dRICH large sensor for focal point region studies

Open cpecar opened this issue 2 years ago • 9 comments

Briefly, what does this PR introduce?

Adds two new optics debugging mode for dRICH: 4 - creates large photosensor instead of default dRICH sensors, designed to catch all possible reflected photons. This is currently used with test 12 / 14 in drich-devs, throwing parallel beams of photons in order to determine the focal region of the dRICH optics. 5 - from a local text file, creates representations of the calculated focal points from mode 4 and a script in drich-devs, and also creates default dRICH sensors to visually compare calculated focal point to sensor position.

What kind of change does this PR introduce?

  • [ ] Bug fix (issue #__)
  • [x] New feature (issue #__)
  • [ ] Documentation update
  • [ ] Other: __

Please check if this PR fulfills the following:

  • [ ] Tests for the changes have been added
  • [x] Documentation has been added / updated
  • [x] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

cpecar avatar Jan 13 '23 18:01 cpecar

Looks good to me. Where should we store your code to calculate the focal points? Here or in drich-dev?

c-dilks avatar Jan 13 '23 20:01 c-dilks

The focal point determination script is already in drich-dev (PR #55 in drich-dev), so I would say there makes more sense.

cpecar avatar Jan 13 '23 20:01 cpecar

@cpecar I updated this branch w.r.t. main and resolved conflicts (hopefully correctly).

c-dilks avatar Jan 25 '23 00:01 c-dilks

@cpecar @c-dilks What is the status on this PR? Do we want to complete this before end of March to include in campaign?

wdconinc avatar Mar 22 '23 02:03 wdconinc

@cpecar @c-dilks What is the status on this PR? Do we want to complete this before end of March to include in campaign?

This isn't needed for the campaign; it supports an ongoing study for sensor placement optimization.

@cpecar there are still some review comments to resolve.

c-dilks avatar Mar 22 '23 04:03 c-dilks

Is this branch still under development? Can you rebase, fix merge conflicts, and comment when it's ready?

wdconinc avatar Oct 01 '23 18:10 wdconinc

Is this branch still under development?

Adding @chchatte92. Can you pick this up if needed, or close if not needed?

wdconinc avatar Oct 14 '23 15:10 wdconinc

Sorry, I should have finished this a while ago and the PR has fallen behind a a good bit in terms of how the sensors are now defined. I’ll wait for word from Chandra on if this would still be a useful feature and if so I’ll bring it up to date and finalize it.

cpecar avatar Oct 14 '23 22:10 cpecar

@cpecar @chchatte92 We are tagging a new release for February simulation campaign? What's the status of this PR? Is it supposed to be merged or no?

rahmans1 avatar Feb 07 '24 03:02 rahmans1