Wouter Deconinck
Wouter Deconinck
@spackbot fix style
> Please note #44860 and #44861. Ha, I overlooked those. I will review them.
> It does look like your specs are a bit more elaborate in some cases; perhaps we should use yours instead! Since you were first and therefore deserve the credit...
This PR is now ready for review. It doesn't add the new packages, and only adds v35.1.0 and v35.2.0. `fastor` has since been added to `develop` in a separate PR;...
Closing in favor of newer https://github.com/spack/spack/pull/45569.
In light of @HadrienG2 (sorry, one last notification) message in #45071, after many years of dedication to these packages, I think we can go ahead and merge.
```console $ curl -L https://mirror.spack.io/_source-cache/archive/20/208316c2564bdd5343fa522f3b230d84bd164058957059838df7df56876cb4ae > /tmp/lua-pkgconfig.old.patch $ curl -L https://github.com/guix-mirror/guix/raw/dcaf70897a0bad38a4638a2905aaa3c46b1f1402/gnu/packages/patches/lua-pkgconfig.patch > /tmp/lua-pkgconfig.new.patch $ diff -w /tmp/lua-pkgconfig.old.patch /tmp/lua-pkgconfig.new.patch 1,3c1,6 < diff -Naur lua-5.3.0.orig/Makefile lua-5.3.0/Makefile < --- lua-5.3.0.orig/Makefile 2014-10-30 00:14:41.000000000 +0100...
The close intersections are not within the same volume, i.e. `vol=18|bnd=1` vs `vol=20|bnd=4`. These are: ```json { "boundary": 1, "value": { "bounds": { "type": "RadialBounds", "values": [ 34.0, 241.00199999999992, 3.141592653589793,...
Coming back to this, two other pieces of the puzzle (but unfortunately due to point 1 it probably doesn't make sense to add the verbose output of the propagator since...
> The reason for this appears to be because these positive endcap layers are off axis, but the cylinder volume builder still uses the simple radial bounds to construct cylinders,...