Adrian Brock

Results 191 comments of Adrian Brock

Ok, so you can in principle regenerate the node data from the pipes. But doesn't that mean forced chunk loading to do recalcuations of things like cable route paths or...

I am not saying this is not doable, but the purpose of this is to try to fix old data. A hackier/easier alternative is to just copy the old data...

We seem to have crossed and have had the same idea?

ok, i will give that a try and see what problems I find. The most obvious one is where there is already a conflicting blockpos in the data. In that...

Ok, I have committed a fix that automatically moves the old data into the new data as Archengius suggested. This looks to be working except for the overlapping blockpos which...

For the overlapping blockpos of pipenets in different dimensions this is worse than I thought. I had thought the getNetFromPos() would choose a random pipenet based on how it processes...

Actually the "It won't attempt to fix it" is only half true. If there is another pipe in the same pipenet that does not overlap with a pipe in a...

I have done the changes you asked for, with one exception. getCompoundTag() already does the hasKey() test with the additional check that it is actually a compound tag (type 10)....

On the main issue, I can see that putting the check for old data at the end of getNetPos() is slightly more efficient. I have done this and it works....

>As an aside. I think the FluidPipeFluidHandler could actually be resolved once and shared between all fluid pipes in the pipe network? Its only reason to be in the pipe...