Andrey Rakhmatullin
Andrey Rakhmatullin
This is interesting. There is #3529, I wonder if this change is about the same problem and solves it. There may be some other recent discussions about this, not sure...
This should be a good time to introduce a stable and documented API for download handlers, with async functions and other updated expectations (e.g. I would deprecate and later forbid...
A more specific proposal: 1. Document the API, as having `lazy`, `def from_crawler()`, `async def download_request()` (without a spider arg, #6763) and `async def close()`. Say that this is how...
Can you please explain why do your tests fail if you ran them before submitting?
Hello! Can you please tell us if you are still planning to work on this? Thank you!
Obligatory "I wonder how to test this". I'm also not sure if enabling this if and only if `JOURNAL_STREAM` is set is correct (but then I'm not sure what should...
@AliAlimohammadi at the very least you should fix the CI failures and make sure you run these checks locally before pushing.
> But we wanted to raise an exception. Unless you want me to gracefully raise an exception in try block? It doesn't look like you understood what I said, do...
Have you tested these changes? If so, can you please describe how?
> systemd-python requires system development libraries (libsystemd-dev) to build from source, which aren't available in the CI environment. It should be possible to install it in `tests-ubuntu.yml` like we already...