Andrey Rakhmatullin
Andrey Rakhmatullin
Can you please try writing automatic tests for this?
The tests your model generated for you don't really test anything except the stdlib. I don't think they are useful.
> What level of testing do you actually want for optional features? At least some level, instead of checking that your mock indeed subclasses `logging.Handler` > I think proper testing...
I don't plan to review these excessive fully AI-generated tests that don't seem to do anything, sorry. You basically need to test one thing: that enabling the systemd logger and...
Seems to be introduced by #6729 Note that you don't really need `start_requests()` or `start()` here as you can use `start_urls`.
Interesting that on master this doesn't output anything at all :-/
> Interesting that on master this doesn't output anything at all :-/ Bisected to #6852
No log output in master can (and should) be fixed by limiting the `queue` size in `_parallel_asyncio()`. A benchmark, using the following code: ```python from scrapy import Spider, Request class...
I feel like the main remaining difference between master and 2.12 is in `send_catch_log_async()`/`send_catch_log_deferred()` and my PoC rewrite of the former to use `asyncio.gather()` instead of wrapping the latter raises...
> Is there an estimated release date for version 2.14? We don't have specific dates but we want to release it in the next couple of months. There are still...