Andrey Rakhmatullin comments

Results 562 comments of


                                            Andrey Rakhmatullin

tests: integration coverage for memusage extension

> It does It indeed doesn't. I'm pretty sure it's an instance of #6916. It may even be related to #3343, though I can't reproduce that one on master with...

Reducing memory footprint of `Request` object: slots and lazy evaluation

I think this broke tests.

Reducing memory footprint of `Request` object: slots and lazy evaluation

> is there any point for writing tests for setters? Yeah, I think it's useful to make sure the attributes can be assigned, for these and future changes.

Drop support for python 3.9, move from 3.14-rc to 3.14

https://github.com/scrapy/scrapy/pull/7089#issuecomment-3397437901

Cannot disable middleware in settings when referencing middleware by its object

@anoofmhd you can work on it without being assigned.

Cannot disable middleware in settings when referencing middleware by its object

> Would it be okay if I proceed? Sure.

Cannot disable middleware in settings when referencing middleware by its object

@asharmalik19 sure

Cover `scrapy.extensions.memusage.MemoryUsage` with tests

@Lions-1 sure, you don't need a confirmation for that

Cover `scrapy.extensions.memusage.MemoryUsage` with tests

@meet-vasita note that there are open PRs for it already.

Cover `scrapy.extensions.memusage.MemoryUsage` with tests

@luca-c-coll please follow https://docs.scrapy.org/en/latest/contributing.html#finding-work