Andrey Rakhmatullin

Results 562 comments of Andrey Rakhmatullin

I haven't tested the code myself but the proposed PRs suggest this is 2 lines of code after we have #7044.

@Suchi1905 please read and follow https://docs.scrapy.org/en/master/contributing.html

This will also break with Scrapy 2.14 when that's released.

There are also itemloaders.

I meant the latter, but now I've checked the docs and I see that "Under the hood, itemloaders uses itemadapter as a common interface. This means you can use any...

I just think that there is a ton of existing item classes in the wild and it would be nice to have a straightforward guide for replacing them.

We've discussed this with @kmike, points: 1. Items have a benefit over dataclasses by having all fields optional by default. Though dicts also have this. 2. @kmike thinks we cannot...

At least the existing tests work (#37)

https://docs.python.org/3.14/howto/annotations.html Also "typing-extensions provides a backport of get_annotations() that works on earlier versions of Python.", we may need to use that.

This is ready for review and discussing the API.