Andrey Rakhmatullin
Andrey Rakhmatullin
https://github.com/scrapy-plugins/scrapy-playwright/pull/357 proposed scrapy-playwright changes
I've just had a similar thought recently. So in general the reason for the key being like that is, IIRC, because of nested settings that are also loaded into a...
A very quick review: - the fix for #5383 just narrowed down the possible types, it doesn't really mean anything other than strings is actually useful - there are no...
It doesn't look like you ran your test?
That's a rare failure likely introduced by changes in #6997, you should ignore it
Please run the tests before submitting
The `scrapy.shell` code that deals with this is also dirty, calling private methods directly and otherwise doing things not expected by `ExecutionEngine` code itself, it would be nice if it...
@nitinjadhav888 sure
This is a good start but I would remove all tests that check internals of the extension and add tests that run a crawl and check that it finishes with...
Please make sure the tests work locally before publishing the changes.