Vít Ondruch

Results 259 comments of Vít Ondruch

> > I also don't recall why jruby isn't in the test matrix, maybe just oversight. > > They were probably failing at some point: [27d23c4](https://github.com/excon/excon/commit/27d23c47561e7fb762679af0f55e316dbce28033) Trying to re-enabling the...

Hm, failures (not due to JRuby). It might not be that easy after all :cry:

These are two variants of the failures: ~~~ Excon streaming basics http + returns true simple blocking request on streaming endpoint + returns ["Hellostreamyworld", "response time ok"] simple blocking request...

I haver run the test suite 100 times in a loop without issues. It might be also some GH CI issue, running multiple test suites in parallel on single machine,...

I wonder how to restart the CI?

> If you go to the actions page (clicking details next to one of them, for instance), you can scroll to the top and choose to re-run jobs. Is that...

Playing with the test suite in my repository, I don't think these are new issues. Here are my test runs: https://github.com/voxik/excon/actions/runs/5574434549 I have mistakenly executed them against the current master...

The Rails `main` branch requires Ruby 3.2+. The test matrix likely needs update to include Rails 8.0, etc, but that is out of scope for me.

I was about submitting PR to drop the base64 and found it here (would be nice if it was independent PR IMHO). And I just wanted to point out that...

> Hmm, I don't remember the : syntax being intentionally one argument only but then it's been a while. But in that case this is a documentation issue. I'd argue...