globalid icon indicating copy to clipboard operation
globalid copied to clipboard

Keep using URI RFC2396 parser

Open voxik opened this issue 11 months ago • 1 comments

The default parser in URI 1.0.0 / Ruby 3.4 has been changed to RFC3986 [1]. This causes test failures such as:

... snip ...

Failure:
GlobalIDTest#test_invalid_app_name [test/cases/global_id_test.rb:13]: ArgumentError expected but nothing was raised.

rails test test/cases/global_id_test.rb:8

F

... snip ...

where underscores / ampersands are now allowed in host. Keep using URI RFC2396 for compatibility.

Just FTR, I am not sure if this is the correct test. Maybe the failing test cases should be adjusted according to RFC3986 and underscores / ampersands allowed 🤷

Fixes #190

voxik avatar Dec 13 '24 12:12 voxik

The Rails main branch requires Ruby 3.2+. The test matrix likely needs update to include Rails 8.0, etc, but that is out of scope for me.

voxik avatar Dec 13 '24 12:12 voxik