Vladik Romanovsky

Results 183 comments of Vladik Romanovsky

@fossedihelm Thanks for the review! wrt: > "Maybe it's worth it to add something to the release note, informing that the VMI node selector does not show Realtime/SEV selector anymore....

> > I wouldn't, these nodelectors had no meaning for the VMI and didn't need to be there in the first place. > > Agreed. My only concern was that...

Looking a the new migration controllers, it seems like there is a lot of duplicated code... For example, the `updateStatus`, all of this interaction with the launcherClients and cleanups. I...

What I mean is that we can have a `MigrationBaseController` where we will implement the UpdateVMIStatus, Cleanup and separate the client handling logic. Then: ``` type MigrationSourceController struct { MigrationBaseController...

Thanks @xpivarc . /unhold I'm not against this change. I just wanted to make sure that we are following https://github.com/kubevirt/community/pull/251 going forward.

/approve Thank you @mhenriks !

@jean-edouard did you have a chance to go over this PR?