community icon indicating copy to clipboard operation
community copied to clipboard

community: generate sig-list.md

Open dhiller opened this issue 1 year ago • 7 comments

What this PR does / why we need it:

Creates an overview over all the user groups, sigs and committees that are defined via sigs.yaml. Output is part of this PR as sig-list.md.

Also corrects a couple of labels for the sigs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

/cc @aburdenthehand @xpivarc

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:


dhiller avatar Jul 22 '24 16:07 dhiller

Cool! Great stuff!

Is there a way to ensure this list is not getting outdated over time?

iholder101 avatar Jul 22 '24 18:07 iholder101

Cool! Great stuff!

Is there a way to ensure this list is not getting outdated over time?

I thought of this as the first step - in another step we can set up a job that automatically updates via a PR whenever sigs.yaml gets changed.

dhiller avatar Jul 23 '24 07:07 dhiller

As an alternative we could create a presubmit that tells people they need to call make generate as we do in k/kubevirt.

dhiller avatar Jul 23 '24 07:07 dhiller

both alternatives sound great @dhiller! thanks!

iholder101 avatar Jul 23 '24 10:07 iholder101

@aburdenthehand updated, thanks for the valuable input!

@xpivarc would you be able to give this another review?

dhiller avatar Jul 26 '24 08:07 dhiller

/lgtm

aburdenthehand avatar Jul 29 '24 11:07 aburdenthehand

/approve

:grimacing:

dhiller avatar Aug 21 '24 13:08 dhiller

This PR is waiting for three weeks now.

Hey @cwilkers @davidvossel @fabiand @rmohr @vladikr :wave:

Since @aburdenthehand is out for a while, is one of you able to take a quick look and approve this?

dhiller avatar Aug 22 '24 13:08 dhiller

Nice! /approve

vladikr avatar Sep 04 '24 13:09 vladikr

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller, vladikr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Sep 04 '24 13:09 kubevirt-bot