community
community copied to clipboard
kubevirt
membership, policy: add SIG, WG and subproject roles
What this PR does / why we need it:
As a followup to #301 this PR adds roles:
- SIG chair
- SIG Subproject Lead
- WG chair
Fixes a couple of header size issues in existing parts along the way.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
- [ ] Design: A design document was considered and is present (link) or not required
- [ ] PR: The PR description is expressive enough and will help future contributors
- [ ] Code: Write code that humans can understand and Keep it simple
- [ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
- [ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
- [ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
- [ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
- [ ] Community: Announcement to kubevirt-dev was considered
Release note:
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
@dhiller My gosh you're quick. Thanks for putting this together. Yeah, I think this is a great start. The table seems pretty solid, however I can see some more things to add or change in the descriptions - probably already known since this is a draft.
Hey @aburdenthehand thanks for your review - I've elaborated on the roles a bit, hope that works better now.
Along the way I've fixed some issues with markdown header levels in the remaining document, and I've added some links so that you can get to the role faster.
PTAL, thank you for your time!
I've suggested summaries for these new roles, similar to what we have for the established roles. I also found a couple of nits.
Thank you @aburdenthehand for the review, I've added the suggestions, PTAL! :pray:
This PR is waiting for three weeks now.
Hey @cwilkers @davidvossel @fabiand @rmohr @vladikr :wave:
Since @aburdenthehand is out for a while, is one of you able to take a quick look and approve this?
Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.
After that period the bot marks them with the label needs-approver-review.
/label needs-approver-review
@EdDev I have updated the PR and addressed your comments with this commit: https://github.com/kubevirt/community/pull/306/commits/3eff9bad87f71725e30563c8ee884427123cdf30
PTAL, thank you!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vladikr
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [vladikr]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment