Vladik Romanovsky

> > @dhiller Ok, I think it's fine. In this case, we just need to make sure that we don't merge these PRs too fast, to allow people some time...

> You are right I don't have any negative tests, I can add some, I am trying to not introduce a bunch of tests that do the same thing as...

@awels, I didn't find anything critical, and the PR looks good to me. /approve @jean-edouard @fossedihelm could you please take another look?

@alaypatel07 From my point of view, the reconciliation of devices should happen in virt-handler. This is also needed to enable the live migration case - to make sure that the...

Overall, this looks very good. I'll approve it in principle, and let's work out some of the minor issues. /approve

> > I think @alaypatel07 has a point. Here we know for sure there's a task to handle that the controller can not perform currently. I think it should explicitly...

/cc @alaypatel07

@aerosouund That's an impressive work! Thank you. Have you considered splitting this work into a collection of PRs? Otherwise, it is nearly impossible to review this as a single change.

/approve Looks good in principle