Martijn Visser

Results 193 issues of Martijn Visser

Currently we use the Pandas NumPy backend. Nowadays pandera also supports the Pandas [Arrow backend](https://pandas.pydata.org/docs/user_guide/pyarrow.html), as well as [polars](https://pola.rs/), which is also based on Arrow. Given that we make a...

enhancement
python
v1.0

So far, the core doesn't do anything with geometries. But if the edge linestring does not start at the from_node_id node point to the to to_node_id node point, that can...

validation
ribasim-nl

These types are properly in the docs and in Python as far as I can see. In the core we don't check them but we'll have to check them as...

python
QGIS
validation

#1697 increased the performance considerably, and passed the tests with only slightly higher tolerances. Surprisingly @Fati-Mon observed this behavior on a Basin running dry: ![image](https://github.com/user-attachments/assets/c7eaf0cd-862b-489f-ae65-5179a2183896) ![image](https://github.com/user-attachments/assets/04a8c81d-1353-4255-be4b-94a20402f09f) We need to look...

performance
core
bug
v1.0

In QGIS you can select one or more nodes: ![image](https://github.com/user-attachments/assets/5885cba4-b815-46fe-b89a-f9ecc36ab9df) This can be used to show the Node table for those nodes: ![image](https://github.com/user-attachments/assets/441cfebc-ba7b-4c1d-88be-6e23710135bb) However, if you want to see the...

enhancement
QGIS
v1.0

Splitting out of #1632. Since we have not focused on the API of the Julia user, but only the CLI and libribasim, some work is needed for this. - [...

core
DoD

When following the [release process](https://deltares.github.io/Ribasim/dev/release.html) and creating #1654, it is impossible to bump the version numbers before we tag the new version and have the `test_version` in `test_cli.py` pass. ```...

test
CI/CD
python

```python import ribasim from pathlib import Path toml_path = Path(r"d:\repo\ribasim\Ribasim\ribasim_qgis\tests\data\simple_valid.toml") model = ribasim.Model.read(toml_path) ``` `simple_valid.toml` is a TOML file. There is no `database.gpkg` associated with this file. That should probably...

python

@Huite mentioned these improvements in #1627 > The current Install docs don't mention QGIS very explicitly: https://deltares.github.io/Ribasim/install.html Maybe add a section there? I would also suggest adding a note in...

documentation

#716 allowed controlling LinearResistance, ManningResistance and FractionalFlow. That FractionalFlow works now was confirmed with a standalone large model, but not yet in unit tests. That ManningResistance works still has to...

test
control
CI/CD