Raoul v. R.

Results 158 comments of Raoul v. R.

Sorry for the confusion! I've updated the [docs](https://vanruesc.github.io/postprocessing/public/docs/variable/index.html#static-variable-BlendFunction) and the related [Wiki page](https://github.com/vanruesc/postprocessing/wiki/Enabling-and-Disabling-Effects) to better describe how effects should be enabled/disabled. > it's just a cheap blend function at the...

Thanks for the report and sorry for the delay! > That when nothing is selected, everything is bloomed That doesn't sound right.. there might be something wrong with the `SelectiveBloomEffect`....

@asjustis That could be a device issue or an ANGLE bug. The other issue where everything would bloom when the selection was empty is fixed in `[email protected]` but the peer...

Unfortunately, I'm unable to reproduce the issue, but I'm on the lookout for anything related to this bug. My current guess is that there's something wrong with RGBA render target...

The [fade](https://pmndrs.github.io/postprocessing/public/docs/class/src/materials/SSAOMaterial.js~SSAOMaterial.html#instance-get-fade) setting can be changed via the [ssaoMaterial](https://pmndrs.github.io/postprocessing/public/docs/class/src/effects/SSAOEffect.js~SSAOEffect.html#instance-get-ssaoMaterial) property of the `SSAOEffect`. I don't know how this translates to `react-postprocessing` though, maybe @drcmda can provide additional information on that.

Related: https://github.com/vanruesc/postprocessing/issues/219#issuecomment-668572380, https://github.com/mrdoob/three.js/issues/19248 The performance issue is most likely caused by three's `outputEncoding` system. Reflector probably triggers shader recompilations each frame due to alternating output encodings (e.g. renderTarget uses LinearEncoding,...

Selective bloom from `postprocessing` works fine with all recent versions of `three` and there are no issues in [SelectiveBloom.tsx](https://github.com/pmndrs/react-postprocessing/blob/e9bfdefa16adaaf8c221c3152b6e37924f0b124a/src/effects/SelectiveBloom.tsx) either. The changes made in `three` r135 only fixed `Layers` to...

Thanks, that sandbox works on my end too. There are some undesired bloom artifacts around non-selected objects though which are caused by multisampling. MSAA leads to a size mismatch between...

@drcmda I think outlines don't use the main depth texture so that one should work. FYI: I want to get MSAA to play nice with all effects but I haven't...

The `OutlineEffect` doesn't break MSAA; it's still active (green arrow), but the effect performs geometry-based depth comparisons which introduces new aliasing artifacts (red arrow). To my knowledge there is no...