Martin Valgur
Martin Valgur
Hi! Thanks for the fixes. There's an existing pull request incorporating similar changes, plus quite a few others, open here: https://github.com/tomas789/kitti2bag/pull/38. May I ask you to review it and comment...
Including Velodyne data in the odom bag output is definitely a good idea. I think a common logic between raw and odom datasetes to select the types of data (velodyne,...
You are not installing it wrong. There's currently a minor bug in setup.py - the required `packages=['kitti2bag']` parameter is missing and causes normal installation to fail. Installation in development mode...
@thully That's really nice. We should definitely consider merging this into the main codebase. I'm only wondering if it could perhaps be based off pykitti like the rest of the...
Looks like the same issue as in #41.
Here's a minimal launch file to demo `stereo_image_proc` working after the camera topic adjustments: ```xml ```
> why did you decide to go with the click instead of the built-in argparse They are pretty similar, I agree. The main reasons why I preferred click: * The...
I don't have any third parties to invite to review the code right now besides some colleagues, but that would not help much, I think. I think most of the...
You can replace the ```python try: import pykitti except ImportError as e: print('Could not load module \'pykitti\'. Please run `pip install pykitti`') sys.exit(1) ``` lines with `import pykitti`. That way...
While not exactly a solution for the broken docker image, but you can really make do without docker (or at least can create a much simpler image without a full...