Martin Valgur
Martin Valgur
YES, PLEASE. This is quite a headache when trying to re-use the same checks in `package_id` and elsewhere. `self.settings` and `self.options` should not be modifiable in `package_id()`, but it would...
I'm kind of surprised this was included in the 2.5.0 release with the two major bugs still present (`.so` files and symlinks are currently broken, #16527).
Thank you @flopie2009! I will try to merge these changes into the next release. Possibly not in this exact form, but adding support for `rosbags` and ROS 2 is in...
Doesn't the `PyUnicode_AsWideCharString(src.ptr(), &size)` call in this conversion leak memory? > PyUnicode_AsWideCharString returns a buffer allocated by [PyMem_New](https://docs.python.org/3/c-api/memory.html#c.PyMem_New) (use [PyMem_Free()](https://docs.python.org/3/c-api/memory.html#c.PyMem_Free) to free it) on success. On error, returns NULL and...
Closing in favor of #25015.
I patched out the MFC dependency for configure.exe on Windows at #18623, so that version should support all platforms now.
@RubenRBS @uilianries Could you look into the missing arrow binary, please?
@franramirez688 The version bumps part of the PR has been reverted and was not the most significant part of the PR anyway. It fixes some major bugs in the recipe,...