Martin Valgur

Results 231 comments of Martin Valgur

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

I think this is relevant anymore thanks to `libuuid` being replaced by `util-linux-libuuid` everywhere by now?

An equivalent of `/bigobj` flag in MSVC needs to be added for MinGW to fix this. See the following patch on ConanCenter: - https://github.com/conan-io/conan-center-index/blob/master/recipes/ceres-solver/all/patches/2.1.0-0002-fix-mingw-build.patch - https://github.com/conan-io/conan-center-index/blob/master/recipes/ceres-solver/all/patches/2.2.0-0002-fix-mingw-build.patch

Adding `CMAKE_TRY_COMPILE_CONFIGURATION` very clearly fixed the `try_compile()` issues with OpenSSL symbol detection in https://github.com/conan-io/conan-center-index/pull/21389. I'll be adding this workaround just in case for any recipes that make use of compilation...

I would maybe include the following Repology badge in the top comment as well: `[![Repository status](https://repology.org/badge/repository-big/conancenter.svg)](https://repology.org/repository/conancenter)` [![Repository status](https://repology.org/badge/repository-big/conancenter.svg)](https://repology.org/repository/conancenter)

Sounds like automatically determining the correct compute capability of your GPU failed when building the library. I would suggest cloning the repo and checking the output of `python setup.py build`....

Here's an answer from the last time it was asked: https://github.com/conan-io/conan/issues/14482#issuecomment-1678538430 I don't think there have been any improvements to the PremakeDeps generator since that time.

I applied all the suggestions. Thanks! I also noticed that only the `include/urdfdom` path was being exported by `urdfdom_INCLUDE_DIRS` and added `include` to it as well. Here's what the resulting...

@traversaro `urdfdom_TARGETS` is indeed not needed anymore, but I would keep it for backwards compatibility.

@sloretz A friendly ping for a review. The PR should be ready to be merged.