Mark Tyneway
Mark Tyneway
Can I get a review on this @smartcontracts ?
If you rebase this, it will fix the `yarn-monorepo` build
Looks like a linting error ``` contracts/universal/CrossDomainMessenger.sol ║ Line │ Column │ Type │ Message │ Rule ID ║ ╟──────────┼──────────┼──────────┼────────────────────────────────────────────────────────┼──────────────────────╢ ║ 30 │ 5 │ warning │ Variable name must...
@maurelian This needs a rebase and should build fine in CI now that a fix for the build cache was merged
I haven't seen this flake before ``` system_test.go:301: Error Trace: /root/project/op-e2e/system_test.go:301 Error: Should not be zero, but was 0 Test: TestFinalize Messages: must have finalized L2 block ```
Do we want to emit the same events that are on the GPO to make it easy for data analytics? It will now require some abi decoding to get that...
I'm updating the gas snapshot, I'm also not opposed to changing the base that these commits are being opened as a PR against, I feel like the contracts changes are...
Unclear why the hive p2p tests are failing here, must be a flake
Fighting the tests here a bit, we need a plan of action with merging this stuff because I think the tests here are failing due to needing changes in a...
Looks like this now needs a rebase