ctb: Add an assert for unreachable condition

[maurelian]

Description

Adds another assertion to explicitly identify an invariant which was previously implicit.

Tests

No new tests. Since the condition is unreachable it will require a more advanced testing setup than we currently have to check this properly.

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: f55445068b84f6591bf61b2b7279a882373e49bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@eth-optimism/contracts-bedrock	Patch
@eth-optimism/actor-tests	Patch
@eth-optimism/sdk	Patch
@eth-optimism/drippie-mon	Patch
@eth-optimism/message-relayer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[mergify[bot]]

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

[tynes]

Looks like a linting error

contracts/universal/CrossDomainMessenger.sol

║ Line     │ Column   │ Type     │ Message                                                │ Rule ID              ║
╟──────────┼──────────┼──────────┼────────────────────────────────────────────────────────┼──────────────────────╢
║ 30       │ 5        │ warning  │ Variable name must be in mixedCase                     │ var-name-mixedcase   ║
║ 100      │ 5        │ warning  │ Variable name must be in mixedCase                     │ var-name-mixedcase   ║
║ 107      │ 5        │ warning  │ Variable name must be in mixedCase                     │ var-name-mixedcase   ║
║ 291      │ 2        │ error    │ Line length must be no more than 100 but current       │ max-line-length      ║
║          │          │          │ length is 101.                                         │                      ║

[mergify[bot]]

Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review.

[tynes]

@maurelian This needs a rebase and should build fine in CI now that a fix for the build cache was merged

[tynes]

I haven't seen this flake before

    system_test.go:301: 
        	Error Trace:	/root/project/op-e2e/system_test.go:301
        	Error:      	Should not be zero, but was 0
        	Test:       	TestFinalize
        	Messages:   	must have finalized L2 block

[mergify[bot]]

This PR has been added to the merge queue, and will be merged soon.

[mergify[bot]]

This PR is next in line to be merged, and will be merged as soon as checks pass.

[mergify[bot]]

Merge failed. Please see automated check logs for more details.

[maurelian]

@Mergifyio refresh

[mergify[bot]]

refresh

✅ Pull request refreshed

[mergify[bot]]

This PR has been added to the merge queue, and will be merged soon.

[mergify[bot]]

This PR is next in line to be merged, and will be merged as soon as checks pass.