optimism icon indicating copy to clipboard operation
optimism copied to clipboard

op-bindings,op-chain-ops,op-node: System config bindings and integration

Open protolambda opened this issue 2 years ago • 3 comments

Description

This PR:

  • updates the Go bindings to the contracts
  • updates op-chain-ops to use new bindings and deploy the system config
  • update op-node to format the L1 block info tx in the new way, and fill derivation placeholders (apply receipts from system config to the sys config in derivation)

This is part 3/5 to introduce batcher-key and GPO param configuration:

  1. Derivation aware of system config (with placeholders for later actual contract/event changes) - #3787
  2. Contract changes: system config on L1, and updated L2 contracts - #3788
  3. Update bindings, update chainops to use updated bindings and dev-deploy system config, and misc integration like log parsing - #3789
  4. Action-test the batcher key change and GPO params change. - #3790
  5. Spec updates

Do not merge: this is a breaking change, and the other parts of the PR stack should be reviewed first.

Tests

See part 4 with action tests for key rotation and GPO params updating.

protolambda avatar Oct 26 '22 14:10 protolambda

⚠️ No Changeset found

Latest commit: 831602e8990dc98dd1751a2ffbd9dc50ba2252c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 26 '22 14:10 changeset-bot[bot]

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

mergify[bot] avatar Oct 26 '22 14:10 mergify[bot]

Note: need to update this PR to change the L1-info encoding (version byte in batcher address field, and pack GPO params).

protolambda avatar Oct 26 '22 17:10 protolambda

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Oct 28 '22 14:10 mergify[bot]

Semgrep found 1 unchecked-type-assertion finding:

  • op-bindings/bindings/l1block.go: L308

Unchecked type assertion.

Created by unchecked-type-assertion.

semgrep-app[bot] avatar Oct 28 '22 17:10 semgrep-app[bot]

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Nov 01 '22 10:11 mergify[bot]

Ready for review. We should merge https://github.com/ethereum-optimism/op-geth/pull/15 first however, so we can update the go.work and go.mod files to reference the proper geth version. Currently the PR uses go.work only to run tests with the geth changes.

protolambda avatar Nov 01 '22 10:11 protolambda

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Nov 01 '22 21:11 mergify[bot]

Looks like this now needs a rebase

tynes avatar Nov 03 '22 00:11 tynes

Rebased + implemented review comment suggestions

protolambda avatar Nov 03 '22 14:11 protolambda

Same fuzzing issue?

mslipper avatar Nov 03 '22 17:11 mslipper