optimism
optimism copied to clipboard
op-bindings,op-chain-ops,op-node: System config bindings and integration
Description
This PR:
- updates the Go bindings to the contracts
- updates op-chain-ops to use new bindings and deploy the system config
- update op-node to format the L1 block info tx in the new way, and fill derivation placeholders (apply receipts from system config to the sys config in derivation)
This is part 3/5 to introduce batcher-key and GPO param configuration:
- Derivation aware of system config (with placeholders for later actual contract/event changes) - #3787
- Contract changes: system config on L1, and updated L2 contracts - #3788
- Update bindings, update chainops to use updated bindings and dev-deploy system config, and misc integration like log parsing - #3789
- Action-test the batcher key change and GPO params change. - #3790
- Spec updates
Do not merge: this is a breaking change, and the other parts of the PR stack should be reviewed first.
Tests
See part 4 with action tests for key rotation and GPO params updating.
⚠️ No Changeset found
Latest commit: 831602e8990dc98dd1751a2ffbd9dc50ba2252c3
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?
Note: need to update this PR to change the L1-info encoding (version byte in batcher address field, and pack GPO params).
Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.
Semgrep found 1 unchecked-type-assertion
finding:
- op-bindings/bindings/l1block.go: L308
Unchecked type assertion.
Created by unchecked-type-assertion.
Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.
Ready for review. We should merge https://github.com/ethereum-optimism/op-geth/pull/15 first however, so we can update the go.work
and go.mod
files to reference the proper geth version. Currently the PR uses go.work
only to run tests with the geth changes.
Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.
Looks like this now needs a rebase
Rebased + implemented review comment suggestions
Same fuzzing issue?