optimism icon indicating copy to clipboard operation
optimism copied to clipboard

op-e2e: system config action tests

Open protolambda opened this issue 3 years ago • 2 comments

Description

This PR introduces:

  • an action test for batcher key rotation, with reorging, old-key batches, etc.
  • an action test for GPO params updating, with L2 tx on block on boundary and L1 fee in receipts
  • introduces some minor fixes/helpers in the action-testing

This is part 4/5 to introduce batcher-key and GPO param configuration:

  1. Derivation aware of system config (with placeholders for later actual contract/event changes) - #3787
  2. Contract changes: system config on L1, and updated L2 contracts - #3788
  3. Update bindings, update chainops to use updated bindings and dev-deploy system config, and misc integration like log parsing - #3789
  4. Action-test the batcher key change and GPO params change. - #3790
  5. Spec updates

Tests

Testing-only, covers the derivation changes in part 2 and 3 of the PR stack.

protolambda avatar Oct 26 '22 14:10 protolambda

⚠️ No Changeset found

Latest commit: 16fb4acf82cdd8cf84c1518136b63e274b17eb0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 26 '22 14:10 changeset-bot[bot]

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

mergify[bot] avatar Oct 26 '22 14:10 mergify[bot]

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Oct 28 '22 17:10 mergify[bot]

Semgrep found 2 unchecked-type-assertion findings:

  • op-bindings/bindings/l1block.go: L308
  • op-bindings/bindings/systemconfig.go: L246

Unchecked type assertion.

Created by unchecked-type-assertion.

semgrep-app[bot] avatar Oct 28 '22 17:10 semgrep-app[bot]

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Oct 28 '22 20:10 mergify[bot]

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Nov 01 '22 10:11 mergify[bot]

If you rebase this, it will fix the yarn-monorepo build

tynes avatar Nov 02 '22 23:11 tynes

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

mergify[bot] avatar Nov 03 '22 14:11 mergify[bot]