Mark Tyneway

Results 574 comments of Mark Tyneway

I've added some additional functionality to this PR: - Split the withdrawal type into `LegacyWithdrawal` and `Withdrawal` - encoding + decoding with roundtrip fuzz tests of both withdrawal types -...

> i have addressed the issues, thanks for the review

Not sure why this is failing in CI but not locally for me

> @tynes is there an issue with the files checked in / something around the path where it's not able to load in the test cases? Found the source of...

Looks like an ethers peer dep problem with smock ``` 1) L1ChugSplashProxy fallback should throw an error if the owner has signalled an upgrade: TypeError: abi.map is not a function...

The build error is happening in `contracts-governance` which is pretty strange. Perhaps a hardhat versioning thing?

Still trying to get this merged @smartcontracts ?

This needs code to handle the L1 genesis creation

I haven't observed this bug in CI, wondering why its happening

I've resolved the merge conflict, this should be good to review @smartcontracts