twostars

Without a call stack at the very least, it's impossible to say anything concrete about the first one. A call stack is important because it gives us a strong idea...

Okay. I actually know why the second one's happening, as it's something I've fixed before in another project. ``` m_pVB->Lock( 0, 0, (void**)&pVertices, 0 ); ``` This is failing, which...

Right, but which threads are we talking about? Because the client operates in a primarily single-threaded manner. Are we talking about packets? These are pooled in the main thread and...

Okay. Had to sift through the screenshots above because I didn't even recall seeing one about packets specifically, but what is there is fairly vague. Looking at this project's source...

Great majority of my comments were rather nitpicky, and largely dependent on the intentions of the codebase, so take from that what you will. I don't know if it's at...

They include the tooltip and the colour in `CN3UIList::AddString()`. I should note that they use 0xEFFFFFFF as the default tooltip colour to denote that it should use the default colour...

What exactly do you consider N3BaseGame, etc to be here? Are they build configurations for N3Base, separate wrapper projects or what? I might be thinking of it too much from...

I was curious on this myself, and apparently Miles is used in the 1.264 client as well. If accuracy and sticking to the official client is important, I would use...

As an addendum to this, I think they should be converted to relevant enums (e.g. login, game, AI, whatever), rather than macros or constants. Also, unless they were added at...

This is just part of #139 - it's handled by .evtsub through CEventSubManager.