Tamas Vami
Tamas Vami
Yaay, all that list is now gone. I guess we can close this issue and have the rest of the problems in https://github.com/LDMX-Software/ldmx-sw/issues/1176 ?
* For the first one, should we just return empty vector (`return {};` outside the switch statements? * For the 2nd, hmm maybe better to avoid one letter variable names?...
hey @tomeichlersmith your point in https://github.com/LDMX-Software/ldmx-sw/issues/1208#issuecomment-1723386035 is now relevant again since you did drop v3 images recently, right?
So besides ONNX warning, I see this one ``` In file included from /usr/include/boost/smart_ptr/detail/sp_thread_sleep.hpp:22, from /usr/include/boost/smart_ptr/detail/yield_k.hpp:23, from /usr/include/boost/smart_ptr/detail/spinlock_gcc_atomic.hpp:14, from /usr/include/boost/smart_ptr/detail/spinlock.hpp:42, from /usr/include/boost/smart_ptr/detail/spinlock_pool.hpp:25, from /usr/include/boost/smart_ptr/shared_ptr.hpp:29, from /usr/include/boost/shared_ptr.hpp:17, from /usr/include/boost/python/converter/shared_ptr_to_python.hpp:12, from /usr/include/boost/python/converter/arg_to_python.hpp:15,...
hey @EinarElen if you have the chance, can you review this issue and remove what was already done? Also do I understand correctly that running ``` denv cmake -B build...
Thanks @EinarElen ! > There are some warnings that are from ROOT and ACTS and... I don't know what we can do about those Yes I'm a bit worried about...
OK so running ``` just configure -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang just build ``` gives me this list - issue with TString.h, RStringView.hxx --> Outside of our scope - nested namespace --> I...
With `set(CMAKE_CXX_STANDARD 17)` the list is the following. [log-part1.txt](https://github.com/user-attachments/files/16912689/log-part1.txt)
Another question to Tom ``` Ecal/src/Ecal/EcalRawDecoder.cxx:133:48: warning: & has lower precedence than ==; == will be evaluated first [-Wparentheses] bool rid_ok = (w >> (shift_in_word + 7)) & packing::utility::mask ==...
Thanks Tom, I'll have this included in the next batch!