Tim Flynn
Tim Flynn
hmm my intent was to have the docs strongly suggest using the same compiler version we use in CI, but have the build continue with an older "known good" version....
I've pushed what that looks like. We now mentioned recommended and minimum compilers in the "Build Prerequisites" section of BuildInstructionsLadybird.md. Other docs now link to that section.
After this PR, `JsonParser` only has 1 direct user outside of `JsonValue` itself, so I was considering either: 1. Making `JsonParser` only constructible by `JsonValue` and make that 1 user...
Went ahead and included that change here
Does it just need this? ```diff diff --git a/Meta/ladybird.py b/Meta/ladybird.py index c06d0837f4d..c01dd2b30eb 100755 --- a/Meta/ladybird.py +++ b/Meta/ladybird.py @@ -57,7 +57,7 @@ def main(): ) test_parser = subparsers.add_parser( - "test", help="Runs...
We have several HTMLInputElement tests under Tests/LibWeb/Text/input/HTML/ so it should be easy (famous last words) to add another there.
A couple of notes: * New features added to AK should always have unit tests * This implementation feels overly complex and won't work with e.g. temporaries. I don't think...
I don't know that they really need to interact, given that `--enable-autoplay` is just a testing flag. These settings are persistent, so a command line flag shouldn't affect them. If...
We'll see this now when `--enable-autoplay` is present: 
> Not in ~/.config? Yeah that probably makes more sense. #4076.