ladybird icon indicating copy to clipboard operation
ladybird copied to clipboard

CI: Update to GCC 14 and Clang 20

Open trflynn89 opened this issue 11 months ago • 4 comments

trflynn89 avatar May 12 '25 23:05 trflynn89

Your clang docs changes seems to bump the minimum clang version to 20. We can probably keep that at 18 or 19

ADKaster avatar May 13 '25 04:05 ADKaster

hmm my intent was to have the docs strongly suggest using the same compiler version we use in CI, but have the build continue with an older "known good" version. Which is how it should behave via find_compiler.sh.

The only places that mention a minimum version in the docs are CLionConfiguration.md and the Custom CMake build directory section of BuildInstructionsLadybird.md. I'd think I'd actually rather them not mention specific versions at all, and instead just link to the recommended versions in the installation steps.

trflynn89 avatar May 13 '25 10:05 trflynn89

Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest master.

github-actions[bot] avatar May 13 '25 10:05 github-actions[bot]

I've pushed what that looks like. We now mentioned recommended and minimum compilers in the "Build Prerequisites" section of BuildInstructionsLadybird.md. Other docs now link to that section.

trflynn89 avatar May 13 '25 11:05 trflynn89