Tim Flynn

If anyone happens to pick up `Intl.Collator`, this branch started work on that object: https://github.com/trflynn89/serenity/tree/intl_collator Note the commit `LibUnicode: Parse and generate Unicode locale extension keywords` is wrong, that ended...

A few of these are reading into a byte buffer a-la `ByteBuffer::create_uninitialized`, but of a static size. Can we use e.g. `Array` instead to avoid extra allocation? See: https://github.com/SerenityOS/serenity/blob/master/Meta/Lagom/Tools/CodeGenerators/LibUnicode/GeneratorUtil.h#L337 for...

> Hmmm. That doesn't handle OOM for allocating the array though, right? Arrays aren't heap allocated

Draft until the corresponding ECMA-402 change is merged

> This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank...

Can you post a before and after screenshot to help with review?

Draft for now because: ``` Diff Tests: -63 ✅ +63 ❌ ``` These are the tests under `test/built-ins/RegExp/property-escapes/generated`. Code point properties apparently changed quite a bit. Full diff Diff Tests:...

All tests pass! ``` Diff Tests: +75 ✅ -75 ❌ ``` Test diff Diff Tests: test/built-ins/RegExp/property-escapes/generated/Alphabetic.js ❌ -> ✅ test/built-ins/RegExp/property-escapes/generated/Assigned.js ❌ -> ✅ test/built-ins/RegExp/property-escapes/generated/Case_Ignorable.js ❌ -> ✅ test/built-ins/RegExp/property-escapes/generated/Cased.js ❌ ->...

Are these tests still correct? The default style is now `short` as of https://github.com/tc39/proposal-intl-duration-format/commit/b28949490bd0bea23e09e31bdeb8847e996482f4 So `basic-format-en.js` should result in `1 yr, 2 mths, 3 wks, 3 days, 4 hr, 5...

FWIW my comment was partially addressed in #3640 - that PR (now merged) ended up with the fix for `basic-format-en.js`, so that can be dropped from this PR. I think...