Tim Flynn
Tim Flynn
kmalloc.h is an ancient artifact from Serenity's kernel using AK. It is not a good argument to break naming conventions in new files.
> Why did the "The android build is broken" banner get removed if the android build is still broken? Because at the time it was removed, the build was working....
I haven't tried personally, I'm guessing that was the issue in #4852 though.
Looks like the only thing that didn't work was using `str | None` in type annotations, so I switched those to `Optional[str]`. System python works for me (3.9), but mileage...
After running with this exclusively for the last day, I was annoyed by spam from ctrl+c (we'd get a full stack trace from python for a `KeyboardInterrupt`). So I've updated...
Element Clear was implemented in #1727
Same comment here about the commit category (should be UI/AppKit), but this doesn't seem to actually fix the issue for me
Do we then still need c0f0f45b6eff64e61593251c5e06deda09d726cf?
I highly, highly recommend talking about major architectural changes with maintainers on Discord before spending time on an implementation.
This seems to break the find-in-page feature: Before this change: https://github.com/user-attachments/assets/1ebde85d-5040-43c0-8c47-3feec3728537 With this change: https://github.com/user-attachments/assets/c7b3cac2-b3ca-4d98-a959-75d7ec4115e7