ladybird icon indicating copy to clipboard operation
ladybird copied to clipboard

Published 20 hours ago • verified publisher icon LadybirdBrowser

LibWebView+WebContent+UI: Migrate autoplay settings to `about:settings`

Open trflynn89 opened this issue 8 months ago • 4 comments

https://github.com/user-attachments/assets/273a0a08-299b-4b8b-8ef4-00b9affb2cba

The dialog will look nicer once we support dialog::backdrop :) Light mode:

autoplay

trflynn89 avatar Mar 29 '25 12:03 trflynn89

How do we expect the "Enable on all sites" toggle to interact with the --enable-autoplay command line option?

Previously, setting the command line option would set the UI checkbox, but with this change setting the CLI flag doesn't' set the UI option.

tcl3 avatar Mar 29 '25 23:03 tcl3

I don't know that they really need to interact, given that --enable-autoplay is just a testing flag. These settings are persistent, so a command line flag shouldn't affect them. If anything, I'd just disable the autoplay "Settings..." if the flag is present.

trflynn89 avatar Mar 30 '25 12:03 trflynn89

If anything, I'd just disable the autoplay "Settings..." if the flag is present.

IMO this, plus a little message by the setting that the flag has force-enabled it.

AtkinsSJ avatar Mar 30 '25 12:03 AtkinsSJ

We'll see this now when --enable-autoplay is present: autoplay

trflynn89 avatar Mar 30 '25 13:03 trflynn89