serenity icon indicating copy to clipboard operation
serenity copied to clipboard

Published 20 hours ago • verified publisher icon SerenityOS

Base: Tweak Source font

Open electrikmilk opened this issue 2 years ago • 4 comments

This does many tweaks to the Source font. The tweaks mainly apply to the bold weight, but tweaks small things about the Regular weight.

This mainly corrects inconsistencies or the placement of pixels in a glyph.

I tried to pay a lot of attention to how different code looks in this font and adapt it to that since that is its main purpose.

Before: old

After: Screen Shot 2022-09-13 at 23 23 22

Before: source-regular_old

After: Screen Shot 2022-09-13 at 23 04 32

Before: source-bold_old

After: source-bold_new

Before: source-regular_old2

After: Screen Shot 2022-09-13 at 23 29 55

Before: source-bold_old2

After: source-bold_new2

electrikmilk avatar Sep 10 '22 02:09 electrikmilk

Source looks punchier, more pleasing to the eye, especially bold when it blends in code. 🎉 lgtm.

djwisdom avatar Sep 13 '22 13:09 djwisdom

Can you post a before and after screenshot to help with review?

trflynn89 avatar Sep 13 '22 17:09 trflynn89

Can you post a before and after screenshot to help with review?

Yeah sure. Added to the PR description.

electrikmilk avatar Sep 14 '22 02:09 electrikmilk

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why. Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

BuggieBot avatar Sep 14 '22 03:09 BuggieBot