Tim Flynn

Results 191 comments of Tim Flynn

> Error! Emoji data for U+1F3F4_U+E006B_U+E0072_U+E0034_U+E0036_U+E007F.png not found. Please check emoji-test.txt and emoji-serenity.txt. Do these need to be added to the "Emoji Tag Sequence Flags" section of emoji-serenity.txt?

I don't think there are any threads involved here. What is happening is that the child's ref count goes to zero after it is removed from its parent, because nothing...

Note that if we *did* need to keep the object alive to do more work after `remove_child`, we could do this: ```c++ void remove_from_parent() { NonnullRefPtr protector { *this };...

> Before looking at this one thing I don't want to lose is the ability to see these processes in the TaskManager widget. We already can't do that for SQLServer...

Yeah, I did the mach port registry in the RS main.cpp, and in the browser I did `WebView::ProcessManager::the().add_process(WebView::ProcessType::RequestServer, pid)` with the daemon PID

doh - I added the mach registry code to SQLServer by mistake 🙃 if I actually add it to RS, it works

@ADKaster would it make sense for ProcessStatistics to live in LibCore? (or LibSystem? LibProcessStatistics?) Would be nice for SQLServer / RequestServer to not need to depend on LibWebView (and then...

While we figure out what to do with RS, I moved the task manager commits over to #24074 to make use of them now

Not needed anymore now that the UI process is a singleton (which effectively makes RS a singleton as well)

> it seems like we are crashing because `EMPTY_TAG` handling is missing in `Value::to_boolean_slow_case()` Pretty sure that's intentional. We should not have empty values - IIRC the only real-word use...