test262 icon indicating copy to clipboard operation
test262 copied to clipboard

Sync to intl-duration-format PR 119

Open FrankYFTang opened this issue 3 years ago • 5 comments

Sync to https://github.com/tc39/proposal-intl-duration-format/pull/119 Use "unit" type for listFormat

FrankYFTang avatar Aug 29 '22 22:08 FrankYFTang

@ryzokuken @romulocintra @sffc

FrankYFTang avatar Aug 29 '22 23:08 FrankYFTang

Are these tests still correct? The default style is now short as of https://github.com/tc39/proposal-intl-duration-format/commit/b28949490bd0bea23e09e31bdeb8847e996482f4

So basic-format-en.js should result in 1 yr, 2 mths, 3 wks, 3 days, 4 hr, 5 min, 6 sec, 7 ms, 8 μs, 9 ns, as the CLDR uses these abbreviations when the style is short (see here, here, etc.).

Also, I think the style-options-en.js shouldn't have commas separating the values when the style is narrow, i.e. the result should be 1y 2m 3w 3d 4h 5m 6s 7ms 8μs 9ns. The CLDR uses commas between units when the style is short (see here), but not when the style is narrow (see here).

trflynn89 avatar Aug 30 '22 16:08 trflynn89

@FrankYFTang Could you address the comments from @trflynn89 or say why you disagree?

ptomato avatar Sep 14 '22 19:09 ptomato

FWIW my comment was partially addressed in #3640 - that PR (now merged) ended up with the fix for basic-format-en.js, so that can be dropped from this PR.

I think all that remains is addressing the commas in the narrow test in style-options-en.js.

trflynn89 avatar Sep 14 '22 19:09 trflynn89

I think I need to update this PR again after some other spec PRs and test262 PRs merged. Please wait. sorry

FrankYFTang avatar Sep 20 '22 15:09 FrankYFTang

@ryzokuken @sffc I believe now this PR is updated to the latest spec. @romulocintra PTAL

FrankYFTang avatar Sep 27 '22 23:09 FrankYFTang