Trent Mick

I'm not sure what's up here. We are using the latest tape@5 and have some nested tests that don't call `t.end()` on the top-level `test(...`, but we don't have errors....

Note that koa-router@12 was recently released as well: `'12.0.0': '2022-07-19T00:44:50.443Z'` The main change in v12 is: https://github.com/koajs/router/pull/116

> 5.7: Pulling from library/mysql ERROR: no matching manifest for linux/arm64/v8 in the manifest list entries > > I'm using mac m1 > > is there a way to run...

> is there a way to run only koa/router tests? I don't believe the koa-router tests require any of the services (MySQL, Postgres, etc.) running, so you should be able...

> I'm getting this error when running using node Hrm. I cannot reproduce that locally. Can you try to follow my steps to see if if still fails for you?...

Ah, do you have `ELASTIC_APM_ACTIVE=false` in your env? I repro when I set that: ``` % ELASTIC_APM_ACTIVE=false node test/instrumentation/modules/koa-router/old-name.test.js TAP version 13 # route naming /Users/trentm/el/apm-agent-nodejs/test/instrumentation/modules/koa-router/shared.js:159 if (agent._transport.destroy) agent._transport.destroy() ^...

> to test against koa 12 I need to install koa 12 and run the tests? That's right: ``` npm install koa-router@12 @koa/router@12 node test/instrumentation/modules/koa-router/old-name.test.js node test/instrumentation/modules/koa-router/new-name.test.js ``` And we'll...

This could be interesting in combination with https://github.com/elastic/apm-agent-nodejs/issues/1967

If/when this is done, having a reference to this in https://www.elastic.co/guide/en/apm/agent/nodejs/current/starting-the-agent.html might be worthwhile as well.

Bump prio a little bit because the optics of the security warning on the module just for the "hapi" tests is a little poor.