apm-agent-nodejs icon indicating copy to clipboard operation
apm-agent-nodejs copied to clipboard

Published 20 hours ago • verified publisher icon elastic

Ensure nested tests are ended currectly

Open watson opened this issue 6 years ago • 4 comments
trafficstars

See elastic/apm-agent-nodejs#849 for details

Checklist

  • [ ] Update tests
  • [ ] Un-pin tape

watson avatar Feb 18 '19 15:02 watson

This has been fixed for awhile. Looks like we forgot to close the issue for it. 😅

Qard avatar Oct 20 '19 19:10 Qard

If it was me I would consider re-opening this. I created this issue because we, if I understood the problem correctly, technically used tape wrong in that we didn't call t.end() for nested tests. This was then inforced in a new version of tape, but because so many people relied on the broken behavior, the change to tape was rolled back. So while it technically works now, I was under the impression that we used it wrong - hence this issue.

watson avatar Oct 21 '19 09:10 watson

Oh, yep. You're right. For some reason I was thinking we had made the change already.

Qard avatar Oct 21 '19 18:10 Qard

I'm not sure what's up here. We are using the latest tape@5 and have some nested tests that don't call t.end() on the top-level test(..., but we don't have errors. Perhaps tape reversed its position on enforcing this? Anyway... we'll get to it sometime, esp. if/when we switch to using node-tap which does enforce this.

trentm avatar Jul 27 '22 00:07 trentm