Trent Mick

The starter diff I had for this: ```diff diff --git a/package.json b/package.json index 4ddb8e38..e760f5f5 100644 --- a/package.json +++ b/package.json @@ -139,10 +139,10 @@ "dashdash": "^2.0.0", "dependency-check": "^4.1.0", "elasticsearch": "^16.5.0", -...

Consider eslint@8 now.

Note all these dependabot PRs, many of which have been deferred to do as part of this update: https://github.com/elastic/apm-agent-nodejs/issues?q=label%3Adependencies+eslint+in%3Atitle

# 2021-11-09 https://github.com/elastic/apm-agent-nodejs/runs/4159716674?check_suite_focus=true "test-vers (8)" ``` # http2.createSecureServer stream respond node[6717]: ../src/node_http2.cc:1694:void node::http2::Http2Session::ClearOutgoing(int): Assertion `(flags_ & SESSION_STATE_SENDING) != (0)' failed. 1: node::Abort() [node] 2: 0x8cd87b [node] 3: 0x91530a [node] 4:...

Methinks Node's http2 is just crashy in node v8.

# 2021-11-17 https://github.com/elastic/apm-agent-nodejs/runs/4246946944?check_suite_focus=true ``` # http2.createSecureServer stream respond node[5969]: ../src/node_http2.cc:1694:void node::http2::Http2Session::ClearOutgoing(int): Assertion `(flags_ & SESSION_STATE_SENDING) != (0)' failed. 1: node::Abort() [node] 2: 0x8cd87b [node] 3: 0x91530a [node] 4: node::http2::Http2Session::OnStreamAfterWriteImpl(node::WriteWrap*, int,...

# 2021-11-29 https://github.com/elastic/apm-agent-nodejs/runs/4357867667?check_suite_focus=true ``` # http2.createSecureServer stream respond node[5509]: ../src/node_http2.cc:1625:static void node::http2::Http2Session::OnStreamAfterWriteImpl(node::WriteWrap*, int, void*): Assertion `(session->flags_ & SESSION_STATE_WRITE_IN_PROGRESS) != (0)' failed. 1: node::Abort() [node] 2: 0x8cd87b [node] 3: 0x9160bd [node]...

# 2022-05-06 https://github.com/elastic/apm-agent-nodejs/runs/6327744363?check_suite_focus=true with `test-vers (8)` ``` ... # handling HTTP/1.1 request to http2.createSecureServer with allowHTTP1:true # NODE_OPTIONS= node[6023]: ../src/node_http2.cc:1694:void node::http2::Http2Session::ClearOutgoing(int): Assertion `(flags_ & SESSION_STATE_SENDING) != (0)' failed. 1: node::Abort()...

This might always be with node v8... which means it'll never get fixed. We can close this as "won't fix" in the next major when we drop node v8 support.

One issue that has come up with @chrisronline using counters (by cheating and using the internal/private API): ```js apm._metrics.getOrCreateCounter(name[, dimensions], callback) ``` is an unfortunate interaction with changes made in...