Trent Mick

Note to self: Here is a diff to the "test/instrumentation/run-context/fixtures/ls-await.js" test fixture to show triggering this error case. A modified version of this might be good to eventually use as...

Notes for if/when adding cassandra-driver destination context: - A *successful* cassandra-driver query will return a ResultSet from which `queriedHost` can be used for dest context. ``` ResultSet { info: {...

run module tests for fastify

@xxzefgh Okay. If you need help, let me know. You should be able to run that one test file directly to test your changes: ``` node test/instrumentation/modules/fastify/fastify.test.js ```

@xxzefgh Thanks! > One issue is that tests are run against v2 (required in devDependencies), which was already supported. I did locally install v3 and it passed, but I'm not...

Actually we could stand to add `test/sanitize-field-names/fastify.test.js` to the fastify .tav.yml test blocks. Would you be willing to add this patch to your PR? ```diff diff --git a/.tav.yml b/.tav.yml index...

I'm not yet sure what is going on with the `node test/instrumentation/modules/fastify/fastify.test.js` test failure with node 8.6 (in the GitHub Actions-based test above). I cannot reproduce that failure using node...

Ah, yes, I can reproduce locally: this happens when using fastify@3 (now in our package-lock.json file) and node 8.6. Fastify@3 only supports node v10 and later. So, we need to...

It is possible we'll need to add the same guard to the other test files that test fastify, but let's see. We already have a form of that guard in...

run module tests for fastify