Trent Mick

Results 694 comments of Trent Mick

> Why do we reset counters on each reporting interval? That predates me. I (ass)(u)(me) that is by design -- i.e. that the contract for metrics between APM agent and...

run module tests for elasticsearch,@elastic/elasticsearch

# some premature optimization perf notes I digressed slightly to sanity check that the change in ES URL path checking here (from a custom `pathIsAQuery` regexp, to a WildcardMatcher-created array...

@astorm the [spec](https://github.com/elastic/apm/pull/670) for this will get merged tomorrow, so feel free to review this when you get a chance. Thanks.

Hi @Dulajdeshan Do you have a more complete code example that we could use to dig into that "1. Error captured automatically by apm agent" error? Also, could you paste...

@Dulajdeshan Are you able to make a small code example that demonstrates the issue?

Relevant spec section: https://github.com/elastic/apm/blob/main/specs/agents/tracing-instrumentation-aws-lambda.md#api-gateway-v1--v2

See also `@node-redis/client`: https://www.npmjs.com/package/@node-redis/client which lives here: https://github.com/redis/node-redis/tree/master/packages/client Also this v3 to v4 migration guide: https://github.com/redis/node-redis/blob/HEAD/docs/v3-to-v4.md

With [version 3.24.0](https://www.elastic.co/guide/en/apm/agent/nodejs/current/release-notes-3.x.html#release-notes-3.24.0) of the agent there was a [significant re-work](https://github.com/elastic/apm-agent-nodejs/pull/2181) of the async run context handling that is largely responsible for these kinds of issues. However, often it really...

Node v18.0.0 also introduces experimental WebStreams support: https://developer.mozilla.org/en-US/docs/Web/API/Streams_API I'm not sure how necessarily tied together `fetch()` and web streams will be for our instrumentation. In particular the web streams docs...