Trey Pendragon comments

Results 122 comments of


                                            Trey Pendragon

Add scope to custom solr indexers

This will change the indexer signature from ```ruby def initialize(resource:) end def to_solr end ``` to ```ruby def initialize(resource:, index_hash:) end def to_solr end ``` We'll have to change `CompositeIndexer`...

Fedora persister should use a transaction for save_all

@escowles This functionality is removed in F5 isn't it?

Create a version of ActiveRecord::RecordNotUnique

Needs a reproducible test case.

Create a version of ActiveRecord::RecordNotUnique

Right now this will raise an error when it happens, but it won't be consistent.

Fedora adapter(s) should support streaming binary content

Looks like Faraday supports streamed requests now.

Document how to create a simple MetadataAdapter.

@mbklein @awead Would this have been useful or was it just as easy to write it from scratch? Maybe just need documentation?

Document how to create a simple MetadataAdapter.

Renaming.

Document how to create a simple MetadataAdapter.

Advanced Topics: Writing a Metadata Adapter

Add instrumentation hooks

It looks like we can just use `ActiveSupport::Notifications.instrument` to implement this. Looking through things like the AR code base, this seems pretty normal. I...don't think we need to add these...

find_inverse_references_by does not work with alternate ids

@awead You still have to use the ID as the value of the member_of_collection_ids. The alternate ID is just like a slug, a Metadata value to find the collection by.