Trey Pendragon

Results 122 comments of Trey Pendragon

:+1: to the more descriptive option.

I don't think so. The interface for Reform is pretty small.

If you want to get the other Params types working, I think that'd be a great addition!

@jeremyf Yeah, it might be that really `adapters` need custom_features too, which would be like ```ruby postgres_adapter.custom_features.transaction do |transaction_adapter| transaction_adapter.persister.save(resource: resource) end ``` Law of Demeter's always going to problematic...

The other option is we just change equality to be something like AR, where if it's persisted it `==` if the two share an ID/class (thanks @jrochkind for digging that...

I'm having a hard time figuring out how we can move this forward. I think I need some use cases where I want two things to be equal to one...

> I like it, except for the temp file naming. I know that's not new, but I think the issue is exacerbated by auto-cleanup. Is there a strong motivation for...

Yeah I think so. It might be nice to use `id_for` in `#upload` too.

Doing this in a feature release will mean checking an indexer's `initialize` method to see if it accepts a scope.