Trey Pendragon
Trey Pendragon
> Where and how that needs to happen can vary, and I don't really want to embed the logic into the adapter. I get that, but the motivation is that...
We could use `Tempfile` maybe, or `disk_path` could accept a block and clean up after itself when the block ends 🤔
> @tpendragon One more consideration on `disk_path`: I want to use x-sendfile to have my web server stream files that are actually on locally mounted file systems. In that case,...
> I ended up fixing the problem [by creating a method](https://github.com/upenn-libraries/apotheca/blob/main/rails_app/app/services/derivative_service/asset/source_file.rb#L21-L39) just like @tpendragon described. It accepts a block and cleans up once the block ends. At the time spent...
I think I'm gonna look at adding a block to `disk_path` and make StreamFile clean up using it, and make `close` on `StreamFile` ensure any local tmp file is deleted.
@dchandekstark @cgalarza How's https://github.com/samvera/valkyrie/pull/955 look?
@dchandekstark Years ago I converted Figgy to cloud only as an experiment and I remember doing a thing for Downloading - https://github.com/pulibrary/figgy/compare/main...figgy_in_the_cloud might be useful to you? (We've since decided...
I'm all for more options! Looking forward to it!
I got this started, but if CI fails I'll have to look at it later.
Closed by #966