valkyrie icon indicating copy to clipboard operation
valkyrie copied to clipboard

Add instrumentation hooks

Open tpendragon opened this issue 7 years ago • 1 comments

MetadataAdapters, StorageAdapters, and ResourceFactories should broadcast messages which can be subscribed to for instrumentation like logging or performance metrics. Look into using https://github.com/krisleech/wisper for these events, and build shared specs and an easy way to implement them in new adapters.

tpendragon avatar Mar 12 '18 18:03 tpendragon

It looks like we can just use ActiveSupport::Notifications.instrument to implement this. Looking through things like the AR code base, this seems pretty normal. I...don't think we need to add these to the shared specs if we do it?

tpendragon avatar Jan 13 '19 14:01 tpendragon