Tom Praschan
Tom Praschan
> > The search bar is sticky so it should be part of the page header, it will look much better. On Android it is very easy, on iOS we...
> I tested it on a low end device to check if embedding a `ListView` inside a `SingleChildScrollView` would not cause performance issues. > > Turn out that the answer...
(converting to a draft until the other PR is merged. I also need to do some more real-world testing)
@veloce what's the process for adding new sound assets? I found the mp3 for the berserk sound in the old app, but looks like for the new app I need...
Did some testing with my local lila instance and fixed some small bugs. I think this is ready to go now :)
> If you cannot convert easily to aifc I can do it myself no worries. The process to add new sounds is to check if the sound is available in...
Ah, the test failed because I had a bug where one side berserking would reset the other side's `berserk` status, fixed now
Awesome, thank you very much!
Thanks for the review! I added two widgets tests now, let me know if you think there's anything else that should be tested
> Just need to change the mocking of data in tests and it's good! Maybe I overlooked your comment about this, or you forgot to submit - What needs to...