Tom Praschan
Tom Praschan
(converted back to a draft, as I'll split some code into smaller independent PRs
@veloce I'm currently thinking about how we should implement the analysis board for studies. We probably want to reuse as much of the existing `AnalysisController`, but it currently expects a...
Thanks for the quick and helpful reply! > I think the `StudyController` should be completely separate from the analysis controller and should have its own logic. > > Over reusing...
> For the broadcast feature, I made a different screen for the analysis board but I reused the analysis controller because I thought the logic was almost the same. I...
Marking this as "Ready to Review" again, as I don't think I can split this up further
I rebased against `main` to fix conflicts with the build_runner PR, also adjusted the formatting of study chapters/members a bit, to avoid the names getting cut off. Here's an updated...
> The one thing I find that's goofy is the open circle bullets for each chapter. I know that's how it is on mobile web but as Veloce says they...
> Thanks Tom, > > Any chance to see both the - and the • as a comparison 😀 I'll wait for @veloce's input here first > Is having circles...
> I've noticed a strange UI freeze when pushing to study screen: > Enregistrement.de.l.ecran.2024-10-29.a.09.34.22.mov > > I don't know what is causing this. It is also on android. > >...
> > Oh, that's not actually a freeze, sorry for not mentioning that, it's just a dummy study screen I added here: https://github.com/lichess-org/mobile/pull/990/files#diff-d6c82c9cf2716bd768ab5fc1abfc30ce85567b52d36230ebdf68f2c616388d56 > > The intention was to make...