mobile icon indicating copy to clipboard operation
mobile copied to clipboard

feat: add tournament support to game screen

Open tom-anders opened this issue 9 months ago • 2 comments

For testing, you'll need to rebase against https://github.com/lichess-org/mobile/pull/1583

tournamentGame.webm

tom-anders avatar Mar 29 '25 23:03 tom-anders

(converting to a draft until the other PR is merged. I also need to do some more real-world testing)

tom-anders avatar Mar 29 '25 23:03 tom-anders

@veloce what's the process for adding new sound assets? I found the mp3 for the berserk sound in the old app, but looks like for the new app I need to convert to .aifc as well?

tom-anders avatar Mar 30 '25 08:03 tom-anders

If you cannot convert easily to aifc I can do it myself no worries. The process to add new sounds is to check if the sound is available in the supported sound themes. Then adding all the required assets.

veloce avatar Apr 01 '25 11:04 veloce

Did some testing with my local lila instance and fixed some small bugs. I think this is ready to go now :)

tom-anders avatar Apr 09 '25 17:04 tom-anders

If you cannot convert easily to aifc I can do it myself no worries. The process to add new sounds is to check if the sound is available in the supported sound themes. Then adding all the required assets.

alright, I added the mp3 from the old app, I couldn't figure out how to get ffmpeg to convert that to aifc

tom-anders avatar Apr 09 '25 17:04 tom-anders

Ah, the test failed because I had a bug where one side berserking would reset the other side's berserk status, fixed now

tom-anders avatar Apr 09 '25 18:04 tom-anders

Not properly merged because it was rebased on main, but effectively merged.

veloce avatar Apr 16 '25 12:04 veloce