Tim te Beek

Results 1243 comments of Tim te Beek

Thanks for the runnable report! Did you already explore why this might be occurring as well?

Figured this might be interesting to @Laurens-W given his ongoing work on - https://github.com/openrewrite/rewrite/pull/6393

Thanks for the clear steps to reproduce this issue @ajoshi66 ! Indeed strange how setting a preferred style leads to removed imports. Admittedly I haven't used explicit styles much myself....

That's unfortunate! Guess we'll need to figure out a fix & update the docs then. /cc @mike-solomon for visibility already

There might be some learnings in this earlier draft that could be applicable here; not sure if you were aware: - https://github.com/openrewrite/rewrite/pull/5575

Noting here that @nomisRev has expressed interest as well for an upcoming v1 of https://github.com/JetBrains/Exposed.

Thanks for the report! Seems indeed like we should ensure we handle annotations nested as annotations arguments correctly.

Thanks a lot for taking this on! Looks good already but I'll have a closer look when I'm back end of next week. One thing we try to avoid is...

Thanks yes the Google bot sometimes gets confused; the [underlying patch file](https://github.com/openrewrite/rewrite/actions/runs/16542462116/job/46785634594?pr=5746#step:12:17) better illustrates the changes it wants to see: ```diff diff --git a/rewrite-maven/src/test/java/org/openrewrite/maven/ChangeDependencyGroupIdAndArtifactIdTest.java b/rewrite-maven/src/test/java/org/openrewrite/maven/ChangeDependencyGroupIdAndArtifactIdTest.java index 997051f..6420ef2 100644 --- a/rewrite-maven/src/test/java/org/openrewrite/maven/ChangeDependencyGroupIdAndArtifactIdTest.java...