Tim te Beek

Results 1243 comments of Tim te Beek

Maybe it helps to look at how we similarly sort elements in OrderPomElements https://github.com/openrewrite/rewrite/blob/fcbc210f7cf6c561d10f7d670b765e20a8f3dd2c/rewrite-maven/src/main/java/org/openrewrite/maven/OrderPomElements.java#L57-L133 And note that that uses a stable list of tags in order; perhaps not quite as...

Hmm, we had intentionally not added a recipe for this, as adding an import by itself could lead to then having an unused import. Instead we handle imports from other...

For that wildcard option we have configurable styles: https://docs.openrewrite.org/concepts-and-explanations/styles That ought to then apply those consistently when you run let's say `OrderImports`. I still feel that's preferred over recipes that...

As much as the help is appreciated, given the concerns outlined in the comments above I propose we close this PR for now: There are better ways to handle imports...

Thanks for the runnable example! Had a brief look. We'll likely need to add something like ```java @Override public J visitNewClass(J.NewClass newClass, ExecutionContext ctx) { J nc = super.visitNewClass(newClass, ctx);...

Thanks for the help here @edeweerd1A ! Just for my own understanding: did the recently added diagnostics not already help pinpoint the cause? Just to know if paths are missed...

Added some more details here now that I've found some time for a closer look: - https://github.com/openrewrite/rewrite/issues/5558#issuecomment-2971150138 Would you mind chiming in there (for SEO) on whether that alternative approach...

Thanks for the report @edeweerd1A ! My first suggestion here would be to use the aligned latest version, as we've both improved diagnostics, as well as resolved a couple of...

Just had a closer look at this; thanks again! So traditionally our approach has been not to put the details in in the exception message (there's limited formatting options there),...

Thanks a lot @jhl221123 ! I've tagged @Jenson3210 to also have a look as I'm out much of the coming week. Seems like a good addition! Have you tried this...